Christian Bandowski

Results 21 comments of Christian Bandowski

Without using this cache it nearly makes it impossible to properly use the aws-iam-authenticator on Windows. For each `kubectl` command you have to enter a new MFA key... Is it...

/remove-lifecycle stale

/remove-lifecycle stale

Thanks for the fast and extensive feedback! Before taking care about your code comments I will start with your first comment: > If I were to design this from scratch:...

Summary from our hangout: * Name the property `usesWithDefaultComponentModel` * Bring it up to date with master

Hi @sjaakd, * Let me know the outcome of your discussion! Would be happy if this PR will be merged and if not then at least I learned more internal...

> I could envision that you only need to specify (a form of) your annotation in stead of a componentModel in the @Mapper annotation. But that would be downward incompatible...

Hi @filiphr , * I started with the same idea to allow specifying the annotation directly, but I choosed the enum so that it is easier to allow different generations...

Oups, sorry! I wasn't aware about the fact that changes in my forked mapstruct repo will directly be linked to this issue. Hopefully I haven't spammed you with too much...

@filiphr: Do you have some special cases in mind where it make sense to write `map[id]` instead of just `map.id` like we are always doing it? Hum... while writing this...