Chris Rands

Results 30 comments of Chris Rands
trafficstars

@edg1983 Thank you- I tested the branch and it works great! Minor suggestion: update `fn: "*.html"` to `fn: "*web_summary.html"` in multiqc/utils/search_patterns.yaml to prevent issues with other .html files

@flying-sheep Still results in `TypeError: norm_impl() got an unexpected keyword argument 'axis'`. Looks like the `axis` arg is removed, as the axis is inferred internally, if I interpret the source...

If you apply the `.roll()` method within the `Seq` class rather than `SeqRecord` it would avoid these complications, but might not be worthwhile. The `.roll()` method reminds me of [`deque.rotate()`](https://docs.python.org/2/library/collections.html#collections.deque.rotate)

There are some tools for helping with automatic type hinting/variable annotation. I'm not familiar with any of them and I think it will require careful review and manual work, but...

I actually just used the script itself, but using the test suite is a good idea and improves the inference: ``` diff --git a/Bio/Seq.py b/Bio/Seq.py index 71818ec89..be9a68279 100644 --- a/Bio/Seq.py...

> The examples show might warrant defining a custom alias for string, Seq (and subclasses), or MutableSeq? Maybe an alias yes, [it's possible](https://docs.python.org/3/library/typing.html#type-aliases); or maybe if alphabets are removed, `Seq`...

I don't know if anyone is working on this (probably not), but I now wonder if it is worth waiting until support for Python 3.6 is dropped before adding variable...

Do you need to use combat? If suggest trying `sc.external.pp.bbknn()`

Great idea! Is conda planning to support this? Did anyone submit a PR?

Hi James, thank you for this PR and functionality! Can you elaborate more on the logic implemented here? From our testing, there are quite a few cases to consider when...