censusxy icon indicating copy to clipboard operation
censusxy copied to clipboard

Track + cache progress

Open Chris-Larkin opened this issue 3 years ago • 3 comments

I have just stumbled on this package and it's brilliant! Huge congrats and appreciation to the authors.

I'm currently in the process of re-writing an old project into R, and have already integrated cxy_geocode into my workflow. I have two small ideas / suggestions for new features:

  1. it'd be great to know how many addresses have been encoded already, or as a % of all addresses. I need to geocode approx. 400k addresses and have set the timeout value to something very large so it should be fine, but it'd be good to know where i am in the process.
  2. it'd also be great if there was a cache feature. I ran into the same problem with my original code for this project (written in Python) using censusgeocode. Like you, i was able to overcome the batch limit of a single call and parallelize, but also cache'd progress just in case the API call breaks. See here for the Python code on this in case that's of interest/use.

I would write a PR for these suggestions but I am sadly still woefully inept in R. Appreciate they're probably pretty low down on your priority list but just wanted to throw them out there! Many thanks again @chris-prener

Chris-Larkin avatar Dec 29 '21 02:12 Chris-Larkin

Thanks for reaching out and appreciate your patience, @Chris-Larkin - I'd certainly entertain PRs for both. Can you do two separate PRs, though, so we can handle the features separately?

chris-prener avatar Jan 10 '22 17:01 chris-prener

No problem. And sorry, but i think you've mis-read my comment. I said I would write a PR for these features but my R is definitely not up to scratch to do that yet unfortunately. I'd love to though, so if my R ever gets good enough you may well see one or two from me :)

Chris-Larkin avatar Jan 11 '22 12:01 Chris-Larkin

oh gotcha! yes - if we haven't added support for either feature by the time you feel up for it, feel free to circle back around. In the meantime, thanks for using the package!

chris-prener avatar Jan 12 '22 01:01 chris-prener