instascrape icon indicating copy to clipboard operation
instascrape copied to clipboard

Incorrect Full Name being returned for Profile Object

Open nickhendo opened this issue 4 years ago • 1 comments

Describe the bug When creating a Profile object, the full_name attribute can be incorrect.

To Reproduce Steps to reproduce the behavior:

  1. Without a sessionid prof = Profile("https://www.instagram.com/atlassian/")
  2. print(prof.full_name)
  3. See that the name returned is Max Sutton (when creating this issue) instead of Atlassian

Expected behavior Expecting prof.full_name to return Atlassian

Additional context I think the issue is in instascrape.core._mappings._ProfileMapping where full_name is mapped to user_full_name. I'm not sure why this is the case, but if this was just mapped to full_name I believe, after my testing, that this should solve the issue. Happy to PR if need be.

nickhendo avatar Feb 18 '21 06:02 nickhendo

Just noticed this happening with the username as well. Added to the PR

nickhendo avatar Feb 18 '21 06:02 nickhendo