Christian Falch

Results 208 comments of Christian Falch

Hi @gurkerl83 - this is something we're aware of, although our first goal was to deliver on iOS/Android and then Web through Expo / RN Web. Feel free to investigate...

Hi @xcoderreal! Thanks for the suggestion - the documentation is type checked against the current version of the library, but not linked to the Examples source (as you say because...

Hi @gtokman! The main README in the root folder contains information about how to run the example project. It is a bit involved since you need to build the Skia...

Hi @evelant! Thanks for the suggestion - we've discussed the asset loading system previously and have decided that we want to keep it as simple as possible so this is...

We're not transferring the bytes over the bridge - React Native Skia will wrap the data for the image in an SkData object that is kept on the native side...

React Native implementation [here](https://github.com/facebook/react-native/blob/main/Libraries/Image/resolveAssetSource.js) for reference

Yes, we already use `dataWithContentsOfURL` in the PlatformContext file that loads images on iOS - so I believe we could try adding resolveAssetSource() and set up some tests to see...

This one is for you, @hannojg :) And for some other fun stuff as well!

Hi @Titozzz! Thanks for the PR! Could you describe which NPEs you're expecting to catch with this fix? I'm positive to merge / include this try..catch, but just wanted to...

Hi. @Titozzz - I've created a PR containing a huge refactor of the base C++ classes where we've also cleaned up a few memory leaks and crashes from Android -...