hhvm-newrelic-ext icon indicating copy to clipboard operation
hhvm-newrelic-ext copied to clipboard

Build status updates: 3.10 stable

Open absalomedia opened this issue 9 years ago • 8 comments

Build sequence now tested on Docker & Travis, with latest HHVM builds. Works with 3.10.x

absalomedia avatar Oct 14 '15 05:10 absalomedia

I can verify this works with 3.11.0 as well. @chregu any thoughts on merging?

paullryan avatar Jan 23 '16 19:01 paullryan

@paullryan hi! do you see transactions with 3.11 and this patch ? All my transactions are displayed as "Root path" (in APM).

gorbunovav avatar Jan 27 '16 15:01 gorbunovav

@gorbunovav New Relic may not support setting of dynamic / individual transaction names, according to what I can make of this https://discuss.newrelic.com/t/how-does-the-nr-agent-determine-a-transaction/32867/2

absalomedia avatar Jan 27 '16 23:01 absalomedia

@absalomedia hmm... I had 3.5.1 before update and some version of this extension from the same date, and I've seen transactions as normal urls. Right after update I've started to see everything as "Root path". There is no any additional info about transactions also, despite I was enabling function level & external services profiling. I run standard php application (Magento store actually) and I have seo-friendly urls, with everything rewritten to index.php, as usual.

gorbunovav avatar Jan 28 '16 08:01 gorbunovav

@absalomedia I've added newrelic_name_transaction($_SERVER['REQUEST_URI']); and now I have transactions named after uris, but there is still no profiling information at all (everything is shown as WebTransaction)

gorbunovav avatar Jan 28 '16 09:01 gorbunovav

@absalomedia I've played with the old version a little. I think I was not correct - trace/profiling data are in place. What I am missing are segments in breakdown table, but it looks, that old version was not filling them too. So it is not issue of this patch. The only difference with the old version, which I see, is automatic transaction naming after URIs. Otherwise I can confirm, that it works ok with HHVM 3.11.1

gorbunovav avatar Jan 28 '16 12:01 gorbunovav

Does this works for 3.12?

dieend avatar Feb 26 '16 02:02 dieend

@dieend it should. I confirmed builds on 3.10 & 3.11 without issue.

absalomedia avatar Feb 26 '16 03:02 absalomedia