Phonograph_Plus icon indicating copy to clipboard operation
Phonograph_Plus copied to clipboard

[Bug]: issue of `mid` (MIDI) file format support

Open pixel2user opened this issue 1 year ago • 2 comments

Bug Summary

Internal Error: error while reading the song file l9.a: No Reader associated with this extension:mid at d9.b.a(SourceFile:115) at player.phonograph.mechanism.tag.SongInfoReaderKt.loadSongInfo(SourceFile:31) at player.phonograph.ui.modules.tag.i1.invokeSuspend(Unknown Source:87) at w6.a.resumeWith(SourceFile:1) at n7.i0.run(SourceFile:1) at s7.h.run(SourceFile:1) at t7.k.run(SourceFile:1) at t7.a.run(SourceFile:63)

Version

1.3.2 (1032)

Steps to reproduce the bug

  1. Open Details for a midi file
  2. A error message is shown by the app in the notification list.

Screenshots or Screen recordings

No response

Environment

Package name: player.phonograph.plus App version: 1.3.2 (1032) Git Commit Hash: e5fd7bf0db27965a967f680490fbedd07dc23f60 Android version: 12 (SDK 32) Device brand: google (by Google)

Other helpful information

No response

pixel2user avatar Nov 09 '23 14:11 pixel2user

Well, you can see this because currently it is not supported to read mid/midi files' tags or matadata.

Since it is not a popular or "regular" file format, there is no plan to support reading it for now.

chr56 avatar Nov 11 '23 01:11 chr56

@chr56 - Why not change the behaviour to not trying to read tags or metadata of not supported media files that play just well? These kind of error messages should only be seen if a kind of debugging mode is activated.

No need to support the reading of the tags or metadata, but the error messages are a bad user experience, because the audio is player without problems.

pixel2user avatar Nov 19 '23 08:11 pixel2user