Incorrect update logic in v2.1.3.2

[Botan626]

Describe the bug

ASF is updating ASFEnhance every time, when executing update command, even though the latest version of ASFEnhance is already installed.

Please read from this post and below on ASF discord server, Archi's responses and log are there: https://discord.com/channels/267292556709068800/332735075315744768/1230118024049070101

[chr233]

got it, I will fix it

[Botan626]

@chr233 not fixed and nothing changed, v2.1.3.3

2024-04-19 19:00:17|ArchiSteamFarm-1|INFO|ASF|UpdateASF() Checking for new version...
2024-04-19 19:00:17|ArchiSteamFarm-1|INFO|ASF|UpdateASF() Local version: 6.0.2.4 | Remote version: 6.0.2.4
2024-04-19 19:00:17|ArchiSteamFarm-1|INFO|ASF|UpdatePlugins() Checking for plugin updates...
2024-04-19 19:00:17|ArchiSteamFarm-1|INFO|ASF|UpdatePlugin() Checking update for ASFEnhance plugin...
2024-04-19 19:00:18|ArchiSteamFarm-1|INFO|ASF|UpdatePlugin() Updating ASFEnhance plugin...
2024-04-19 19:00:19|ArchiSteamFarm-1|DEBUG|ASF|OnProgressChanged() ASFEnhance 0%...
2024-04-19 19:00:19|ArchiSteamFarm-1|DEBUG|ASF|OnProgressChanged() ASFEnhance 100%...
2024-04-19 19:00:19|ArchiSteamFarm-1|INFO|ASF|UpdatePlugin() Patching ASF files...
2024-04-19 19:00:19|ArchiSteamFarm-1|INFO|ASF|UpdatePlugin() Updating ASFEnhance plugin has succeeded, the changes will be loaded on the next ASF launch.

[Botan626]

https://discord.com/channels/267292556709068800/332735075315744768/1230118964898562049

[chr233]

maybe fixed

[Botan626]

maybe fixed

no ASF 6.0.4.1 and ASFE 2.1.8.1 still updating

2024-06-18 13:28:31|ArchiSteamFarm-1|INFO|ASF|UpdateASF() Checking for new version...
2024-06-18 13:28:32|ArchiSteamFarm-1|INFO|ASF|UpdateASF() Local version: 6.0.4.1 | Remote version: 6.0.4.1
2024-06-18 13:28:32|ArchiSteamFarm-1|INFO|ASF|UpdatePlugins() Checking for plugin updates...
2024-06-18 13:28:32|ArchiSteamFarm-1|INFO|ASF|UpdatePlugin() Checking update for ASFEnhance plugin...
2024-06-18 13:28:32|ArchiSteamFarm-1|INFO|ASF|UpdatePlugin() Updating ASFEnhance plugin...
2024-06-18 13:28:33|ArchiSteamFarm-1|DEBUG|ASF|OnProgressChanged() ASFEnhance 0%...
2024-06-18 13:28:34|ArchiSteamFarm-1|DEBUG|ASF|OnProgressChanged() ASFEnhance 100%...
2024-06-18 13:28:34|ArchiSteamFarm-1|INFO|ASF|UpdatePlugin() Patching ASF files...
2024-06-18 13:28:34|ArchiSteamFarm-1|INFO|ASF|UpdatePlugin() Updating ASFEnhance plugin has succeeded, the changes will be loaded on the next ASF launch.

[chr233]

dont get what you means, do you want inatall a spect version rather than the lastest one?

[Botan626]

do you want inatall a spect version rather than the lastest one?

no

with update command ASF shouldn't update latest version of ASFE (in other words re-installing it)

[Botan626]

https://github.com/JustArchiNET/ArchiSteamFarm/wiki/Plugins-development#automatic-updates

[chr233]

got it, fixed in 2.1.8.2, add version check before update

[Botan626]

yes, fixed