go-choria icon indicating copy to clipboard operation
go-choria copied to clipboard

Support deploying external agents with the machines watcher

Open ripienaar opened this issue 1 year ago • 3 comments

Later we'll rename it to plugins watcher once its properly generic.

  • [x] New generic plugins watcher created, heavily machines watcher based so the basic mechanics are known. It's just been made generic
    • [x] Various just renames for machines -> plugins
    • [x] Target dir made configurable rather than assume machines dir - defaults to machines dir
    • [x] Prefix of manager machines configurable from previous hardcoded mm_, this allows agent x and machine x to be managed correctly. Defaults to mm_
    • [x] Machines manager auto agent plugin recreated on plugins
    • [ ] External Agents manager auto agent plugin created like machines manager
    • [x] Integrated for testing into choria compose
  • [x] Old mms command moved to choria machine plugins pack allowing us space to iterate there around things like validation etc
  • [x] Old machines watcher kept - and not compiled in as before - for those relying on it
  • [ ] Docs updated for new plugins watcher not machines watcher

ripienaar avatar Apr 10 '23 13:04 ripienaar

You're probably aware, but just an FYI the choria machine mms command isn't plumbed to match the docs yet. I took a stab but wasn't sure if this should be part of the new plugin system. Only mention it in off chance it was overlooked.

jeffmccune avatar Apr 13 '23 00:04 jeffmccune

Never-mind, I see it: choria machine plugins pack

jeffmccune avatar Apr 13 '23 00:04 jeffmccune

Yeah sorry about that been a bit of turbulence here as I realised it would be impossible to get the “machines” watcher to be more generic and keep working as before.

So there is a plugins watcher now that’s almost identical but can also handle rpc agents and more.

Docs not updated for that will try today.

Such is life on main I am afraid

ripienaar avatar Apr 13 '23 04:04 ripienaar