gas-url-shortener icon indicating copy to clipboard operation
gas-url-shortener copied to clipboard

Link results should be clickable

Open saxobroko opened this issue 6 years ago • 9 comments

On https://saxob.ga/ when you click you result I have made it go to the link in a new tab.

There are other ways to do it instead of opening the link, for exmaple you could make it click to copy.

saxobroko avatar Oct 21 '19 02:10 saxobroko

@saxobroko - I intentionally did not want to hyperlink the result as that may not be what others may've wanted (well, quite honestly I had no way to know 😊).

I did try to have a click-to-copy icon made available next to it but just couldn't code it right :( I suppose that's something which we see in many of such services - a way to directly copy the short URL, without having to select it and then copy 'em manually.

Will see how soon I could make a click-to-copy option made available. Thanks for implementing the solution and sharing your feedback.

choraria avatar Oct 21 '19 02:10 choraria

Maybe adding a button next to the result that says "Copy" would make it better w3schools has a good page on this https://www.w3schools.com/howto/howto_js_copy_clipboard.asp

saxobroko avatar Oct 21 '19 02:10 saxobroko

Hacktoberfest Dibs!

SIGSTACKFAULT avatar Oct 22 '19 23:10 SIGSTACKFAULT

Is this still an issue? I'd like to try working on this if possible.

tulXoro avatar Jul 26 '20 08:07 tulXoro

Is this still an issue? I'd like to try working on this if possible.

yeah that would be great

saxobroko avatar Jul 26 '20 08:07 saxobroko

#44

I'm a little new to HTML and JavaScript so I don't know if it'll work the way intended.

tulXoro avatar Jul 26 '20 10:07 tulXoro

Is this issue solved? will this be tagged as hacktoberfest

0xClint avatar Oct 08 '22 17:10 0xClint

I opened a PR that implements this feature. I don't believe this will be tagged for hacktober fest though.

tulXoro avatar Oct 08 '22 17:10 tulXoro