Jesse Gumm

Results 147 comments of Jesse Gumm
trafficstars

Your suggested changes have all been made.

(sorry, I've made a number of small stylistic changes since my "All done" comment). If you feel good about these changes, I can squash them and force-push if you prefer.)

I'm personally fine with the `number` option being floats or ints, but there is absolutely value in a guaranteed `float` option if a user does want that consistent return type....

I haven't tested it for very large decimal values, but that sounds like a good idea. I'll whip up some tests to see how they're handled, and rework if necessary.

Confirmed, you are correct, whether it will be binary or not is determined by the column info from mysql. I think I agree that we should just return the same...

A few more commits added - added `float` as an option, removed the decode option from the kill query, and added a few more tests for large decimals.

Actually, the `socket_backend_test` passes for me, but I do get a canceled test at the end related to SSL: ``` ssl_tests: successful_ssl_connect_test (module 'ssl_tests')...*skipped* undefined *unexpected termination of test process*...

Actually, perhaps it has to do with an outdated `erlang.mk`. I had to do `make erlang-mk` in order to do the dialyzer tests, so that might be a thing as...

Also, as there is no CI, I literally *just* went through and added CI with [github actions to sql_bridge](https://github.com/choptastic/sql_bridge/actions/runs/6123871633). I'd be happy to try to tweak my github actions workflows...

Thanks! Yeah, I can try to put together a github actions file. As for a Makefile rework, we could either just assume rebar3 exists on the local machine or build...