crop_your_image icon indicating copy to clipboard operation
crop_your_image copied to clipboard

Published 20 hours ago • verified publisher icon chooyan-eng

[PROPOSAL] Give ability to customize the loading indicator

Open PTLam25 opened this issue 3 years ago • 2 comments

Hi! It will be very good to have access to change the progress indicator.

Could you please add a new parameter to the Crop widget, so we can pass our custom progress indicator widget? Many thank in advance.

image

PTLam25 avatar Nov 30 '21 15:11 PTLam25

I have this feature already in PR: https://github.com/chooyan-eng/crop_your_image/pull/49

vixez avatar Jan 10 '22 10:01 vixez

@PTLam25 Thank you for the feedback.

@vixez Thank you for your PR! I'll check this.

chooyan-eng avatar Mar 08 '22 09:03 chooyan-eng

I just added progressIndicator parameter to Crop class. You can check the change in https://github.com/chooyan-eng/crop_your_image/pull/75 .

@vixez I checked your PR and I could make the PR above using your idea. I didn't merge your PR as is but I separated "loading widget" part into https://github.com/chooyan-eng/crop_your_image/pull/75 and fixed param name and how default widget is set. Thanks!

chooyan-eng avatar Nov 15 '22 09:11 chooyan-eng