nanomorph icon indicating copy to clipboard operation
nanomorph copied to clipboard

Comments are un-commented

Open ghost opened this issue 6 years ago • 4 comments

It's late at night, so I'll keep this short. I'm making a framework that uses nanomorph heavily. I've just been playing with it, and I realized that comments are uncommented, meaning the <!-- and --> are removed. This is a bit annoying when debugging my app. Not urgent, but just letting you know it's there.

ghost avatar Dec 11 '18 00:12 ghost

@def0x099 can you clarify exactly what's happening, and maybe include some example code? Chances are you aren't using nanomorph in isolation, so it could be how you are building your DOM that is causing the issue.

JRJurman avatar Mar 16 '19 20:03 JRJurman

Doing <!-- ${somevalue} abc --> could cause "abc" to end up in the html. it has recently been fixed in nanohtml. may that have been the cause?

goto-bus-stop avatar Mar 16 '19 20:03 goto-bus-stop

Might be. This needs a repro tho.

ghost avatar Mar 23 '19 02:03 ghost

Sounds related to https://github.com/choojs/nanomorph/pull/122

bennlich avatar Jul 15 '21 00:07 bennlich