nanocomponent-adapters icon indicating copy to clipboard operation
nanocomponent-adapters copied to clipboard

Individually package the adapters

Open bcomnes opened this issue 7 years ago • 6 comments

It was pointed out in https://github.com/choojs/nanocomponent-adapters/pull/6#issuecomment-359192650 by @alterx that some of these adapters might require heavy dependencies or peer deps. Rather than bundle all those together, we should make each adapter its own repo/module so that people dont have to feel the weight of every adapter.

So... for anyone interested, redo the adapters you are interested in maintaining as a module and we can remove it from this repo, but still reference/export it as a collection since we already have this.

bcomnes avatar Feb 12 '18 01:02 bcomnes

Aye, this sounds great!

yoshuawuyts avatar Feb 12 '18 12:02 yoshuawuyts

I have a repo for an angular.js 1.x adapter over here. How did you imagine the exports from this module would work? Kind of like choo does with bel?

kareniel avatar Feb 12 '18 17:02 kareniel

I would model it after https://github.com/maxogden/mississippi

bcomnes avatar Feb 12 '18 17:02 bcomnes

I wanted to use nanocomponent-adapters to prototype some components at work, which is primarily an Angular shop and noticed that version 3.0.0 had an empty index.js file in there. Anyways, to test this out I published the angular one as a separate package and saw this issue. Need to fill out README, etc. Happy to add everyone to the repo and give publish access. y'all just ping me if you want it.

https://github.com/emkay/nanocomponent-adapters-angular https://www.npmjs.com/package/nanocomponent-adapters-angular

emkay avatar Jun 06 '18 20:06 emkay

Looks awesome, we should point to it from here.

bcomnes avatar Jun 06 '18 21:06 bcomnes

https://github.com/choojs/nanocomponent-adapters/pull/20 💖

emkay avatar Jun 06 '18 22:06 emkay