yank icon indicating copy to clipboard operation
yank copied to clipboard

Published 20 hours ago • verified publisher icon choderalab

Fix/support python 310

Open mikemhenry opened this issue 2 years ago • 4 comments

In python 3.10, Mapping and MutableMapping live in collections.abc and not collections. This supports importing Mapping and MutableMapping from python 3.10 and < python 3.10

We can either add this and bump yank version + cut new yank release OR just change conda-forge to not support python 3.10 for yank since CI is failing https://github.com/conda-forge/yank-feedstock/pull/4

@jchodera do you have a preference?

option 1: merge in PR, bump yank version, new release on conda-forge

option 2: set yank on conda-forge to < python 3.10

Resolves #1301

mikemhenry avatar Jul 20 '22 23:07 mikemhenry

Thanks for fixing this!

Option 1 sounds good. Maybe we can get some other critical bugfixes in as well?

jchodera avatar Jul 21 '22 01:07 jchodera

That is a good idea, if you have time (and I saw that you started this) try and tag any PRs or issues into this milestone https://github.com/choderalab/yank/milestone/11

It would be nice to get some fixes in + get CI working again

mikemhenry avatar Jul 21 '22 17:07 mikemhenry

Resolves #1288

mikemhenry avatar Sep 07 '22 16:09 mikemhenry

@ijpulidos thanks for working on this! We are getting closer! AttributeError: module 'openmmtools.utils' has no attribute 'find_subclass'

mikemhenry avatar May 19 '23 22:05 mikemhenry