perses icon indicating copy to clipboard operation
perses copied to clipboard

Published 20 hours ago • verified publisher icon choderalab

Test new open ffmast fix

Open mikemhenry opened this issue 1 year ago • 6 comments

@ijpulidos do you remember which test(s) we disabled because of this bug?

mikemhenry avatar Sep 28 '23 14:09 mikemhenry

Yes, I'll make the changes in this branch/PR such that we run the tests that were failing with Openmm8. Thanks!

ijpulidos avatar Sep 28 '23 15:09 ijpulidos

Codecov Report

Merging #1237 (e9dff99) into main (6c6419f) will decrease coverage by 2.99%. The diff coverage is n/a.

Additional details and impacted files

codecov[bot] avatar Sep 28 '23 15:09 codecov[bot]

Do we want to merge this in so we can keep these tests running? Part of me is thinking that it could be good to keep these tests running, even if it is using an unreleased beta of the openeye-toolkit.

mikemhenry avatar Sep 28 '23 16:09 mikemhenry

I think it could be worth it to have this in a separate flow (yet another one haha). Is that a reasonable way to do it?

ijpulidos avatar Sep 28 '23 20:09 ijpulidos

We could add it to the matrix (but just do it for one python version and on linux). I am trying to think of the risks of just keeping it as is.

mikemhenry avatar Sep 29 '23 13:09 mikemhenry

I don't see any immediate risks with this. I agree with adding it to the matrix (single python+linux).

ijpulidos avatar Oct 02 '23 15:10 ijpulidos