perses icon indicating copy to clipboard operation
perses copied to clipboard

add docker files

Open mikemhenry opened this issue 2 years ago • 3 comments

Description

These are the docker files I've been using to build images.

Motivation and context

I didn't want to be a single point of failure if we needed to re-build some images, I've just kept these local.

How has this been tested?

@ijpulidos :)

Change log

I don't think this warrants a change log entry.

mikemhenry avatar Aug 19 '22 16:08 mikemhenry

Codecov Report

Merging #1087 (0725260) into main (4e36a6b) will decrease coverage by 0.07%. The diff coverage is n/a.

:exclamation: Current head 0725260 differs from pull request most recent head cca2892. Consider uploading reports for the commit cca2892 to get more accurate results

codecov[bot] avatar Aug 19 '22 17:08 codecov[bot]

Thanks! I was wondering if we need all the docker files here or if we want to always have the "latest". I know some of these have been created specifically for some of our collaborators. In the meantime I'm more inclined to have one or two (maybe one with current release of perses and openmm, and another with the openmm-nightly/dev build). And if we end up needing the other ones we can add them as required. Does that sound okay?

ijpulidos avatar Aug 29 '22 16:08 ijpulidos

How about we keep the two you described, I add a readme on how to build them, and then make a folder that keeps all of the extras if we need them?

mikemhenry avatar Sep 01 '22 07:09 mikemhenry