assaytools
assaytools copied to clipboard
Improving xml2png.py
I was testing xml2png.py with Infinite results of different assay types. I will list here some suggestions:
- Adding usage example with type argument will be useful here: https://github.com/choderalab/assaytools/blob/master/scripts/xml2png.py#L4
- For single_96 type, the plots are too wide. We should adjust plot dimensions.
There is empty space on x-axis for wells bigger than 12 on 96-well plot.
- I think adding axis labels will be great. x-axis label: Well Index, y-axis label: Fluorescence
- Plot title usually has
Noneprinted for'Part of Plate'section.
https://github.com/choderalab/assaytools/blob/master/scripts/xml2png.py#L111-L124
Do we need "Part of Plate" information? Or can we assign a default "Full Plate" when xml doesn't have this information. - I don't have ant 384-well data, so I couldn't test
singlet_384type but I noticed it has hard coded ligand concentration(Lstated) for plotting. Can we remove that? https://github.com/choderalab/assaytools/blob/master/scripts/xml2png.py#L404-L418 - The difference between types
spectraandscanwasn't obvious to me.
Thanks Mehtap!
Could it also be made python 3 compatible?
It may also be helpful if it prints the help string if called without any arguments.
All good ideas!