Guideline: Check for copying to program files and flag

[ferventcoder]

Nothing should have a need to copy to program files without a really good reason. The native installer should make the changes required.

However if someone is just deciding that is where their portable application goes, that is an anti-pattern.

[gep13]

@ferventcoder what was going to be your approach here? There are a number of ways to copy files, and simply looking for usage of Program Files/Program Files (x86) might not be the best way.

Thoughts?

[ferventcoder]

I didn't have a best way yet, it was more linked to looking for use of both program files and any use of copying.

[AdmiringWorm]

I know this is old now, but still. Perhaps, checking if the extraction directory isn't inside the Get-BinDir/Get-ToolsDir or the package Directory or temporary directory would be enough to flag this?

Could cause a false positive for extensions/plugins that need to be extracted to another program install directory though. (So maybe change to a note instead of guideline?)