package-validator (GH-14) Adding additional IconUrl check

To ensure that the IconUrl either comes from the same domain as the ProjectUrl, or comes from the RawGit CDN
Fixes GH-14

Nov 26 '15 20:11 gep13

Fix up the checks a bit so there are no null reference exceptions.

Nov 28 '15 01:11 ferventcoder

@ferventcoder ah, good shout!

I think I have corrected the logic flow. Let me know if you spot any other problems.

Nov 29 '15 14:11 gep13

Always resubmit the same commits unless the new changes add something additional. A code review is not one of them. (same comments for full effect ;) )

Nov 29 '15 17:11 ferventcoder

@ferventcoder just away to head for the night, but will follow up with any comments in the morning. Let me know what you think.

Nov 29 '15 21:11 gep13

@ferventcoder as a start (work still required) is the second commit the type of thing that you had in mind?

Dec 01 '15 13:12 gep13

NOTE: Never used TinySpec before, so very much feeling my way around here, but used some examples from choco in order to create this.

Dec 01 '15 13:12 gep13

@ferventcoder ok, let me know what you think.

Dec 01 '15 20:12 gep13

@ferventcoder ok, so that scenario results in a failed tests, which is what I think you thought would happen :-)

I will look at the regex, and see if there is anything that can be done.

Dec 02 '15 08:12 gep13

@ferventcoder I have added that scenario though, and pushed to this PR.

Dec 02 '15 08:12 gep13

ok, so that scenario results in a failed tests, which is what I think you thought would happen :-)

You caught me :D

Dec 02 '15 14:12 ferventcoder

@ferventcoder what do you think of this change?

Dec 02 '15 20:12 gep13

@ferventcoder what do you think about this alternative approach?

Dec 03 '15 13:12 gep13

@ferventcoder I have fixed up with your comments, and re-pushed.

However... :-(

I started adding in the unhappy paths, as you suggested, and this highlighted an error in the logic. See the failing test.

Any ideas on best approach to go forward? It all comes down to not knowing the valid TLD's in order to move forward. I really don't want to have to start pulling in a complete list of TLD's and comparing against them, as these lists are always changing.

What are your thoughts?

Dec 05 '15 20:12 gep13

I'll need to pull in the PR to see the failing test.

Dec 05 '15 21:12 ferventcoder

@ferventcoder did you have any suggestions about this one, or did you get pulled onto something else?

Dec 06 '15 15:12 gep13

I didn't see the failing test yet. Might be best to comment on the PR files where the failing test is.

Dec 06 '15 17:12 ferventcoder

Is this ready to go?

Dec 15 '15 05:12 ferventcoder

@ferventcoder no, this still has a failing test :-( I keep coming back to this one, and not liking the solutions that I come up with :-(

Dec 15 '15 07:12 gep13