package-validator icon indicating copy to clipboard operation
package-validator copied to clipboard
verified publisher icon chocolatey

Note: Flag the use of setting environment vars directly

Open ferventcoder opened this issue 10 years ago • 4 comments

ferventcoder avatar Nov 25 '15 19:11 ferventcoder

@ferventcoder thoughts on this one? Requirement, note, guideline, suggestion

gep13 avatar Jan 19 '16 09:01 gep13

Note feels appropriate here - depending on what they set it could be a requirement. However if we split this out a bit and look for particular environment vars being used (which I think this was originally about), then note using some chocolatey environment vars would be a requirement.

However this could be the case where we want folks to use the Helper and we are flagging against that - that is a guideline. Anytime folks are skipping our helpers we want to know about it.

ferventcoder avatar Jan 19 '16 14:01 ferventcoder

@ferventcoder okay, so I am hearing that this could actually be three separate rules then, yes?

gep13 avatar Jan 19 '16 16:01 gep13

Seems like it could be - but maybe just two. The setting directly (not using the helper) and then using particular chocolatey environment variables.

ferventcoder avatar Jan 19 '16 17:01 ferventcoder