choco icon indicating copy to clipboard operation
choco copied to clipboard

pack - Nuspec validation on choco pack

Open laedit opened this issue 9 years ago • 7 comments

Like discussed in the mailing list, it would be great if the nuspec validation was done during the choco pack command: it could save time and prevent the submission of incorrect package.

laedit avatar Feb 02 '16 04:02 laedit

Thanks for getting this logged.

ferventcoder avatar Feb 02 '16 18:02 ferventcoder

Some discussion https://gitter.im/chocolatey/choco?at=56fa7f638d2a72471b7b102c

ferventcoder avatar Mar 29 '16 14:03 ferventcoder

This should make sure to validate the character limits of the various nuspec elements as well as things that the validator checks, since those will fail on choco push instead of at the validator. Given the number of people affected by #2007

TheCakeIsNaOH avatar Oct 23 '21 20:10 TheCakeIsNaOH

Also, if this will include the nuspec url validation, I think that should either be disabled by default or possibly toggle-able by a feature switch. This is for anyone building the package inside an offline or locked down environment.

TheCakeIsNaOH avatar Oct 23 '21 20:10 TheCakeIsNaOH

There is a todo comment for this feature request here: https://github.com/chocolatey/choco/blob/develop/src/chocolatey/infrastructure.app/services/NugetService.cs

TheCakeIsNaOH avatar Feb 05 '22 03:02 TheCakeIsNaOH

@TheCakeIsNaOH said... I think that should either be disabled by default or possibly toggle-able by a feature switch. This is for anyone building the package inside an offline or locked down environment.

As we discussed, this would indeed make sense to be able to configure this check.

gep13 avatar Feb 05 '22 15:02 gep13

I believe this is resolved in part, and will be resolved in full, but the recent release of the Community Validation Extension. There was a recent blog post and live stream around it.

pauby avatar Feb 04 '24 09:02 pauby

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue will be closed in 14 days if it continues to be inactive.

github-actions[bot] avatar Mar 06 '24 04:03 github-actions[bot]

Dear contributor,

As this issue seems to have been inactive for quite some time now, it has been automatically closed. If you feel this is a valid issue, please feel free to re-open the issue if / when a pull request has been added. Thank you for your contribution.

github-actions[bot] avatar Mar 20 '24 04:03 github-actions[bot]