chocolatey
(#3465) Allow building an MSI during outside of tagged commits.
Description Of Changes
Update the Recipe used to default to not build an MSI. Update the CI configurations to allow building the MSI with the addition of the --shouldBuildMsi=true parameter.
Motivation and Context
Ease the experience of making adjustments to the MSI. Allow us to get an MSI more regularly for testing.
Testing
- Ran
./build.bat --target=Build-Msi - Noted that it failed to build as a previous task was skipped.
- Ran
./build.bat --target=Build-Msi --shouldBuildMsi=true - Noted that it completed successfully.
- Checked the
code_drop/Artifactsandcode_drop/MSIs/en-USdirectories to confirm that an MSI was generated. - Monitored the GHA for this PR to note that an MSI was generated.
- Monitored the Team City build for this PR to note that an MSI was not generated (because it's not a tagged build and the settings haven't been merged yet)
Operating Systems Testing
- Windows 10
Change Types Made
- [ ] Bug fix (non-breaking change).
- [x] Feature / Enhancement (non-breaking change).
- [ ] Breaking change (fix or feature that could cause existing functionality to change).
- [ ] Documentation changes.
- [ ] PowerShell code changes.
Change Checklist
- [ ] Requires a change to the documentation.
- [ ] Documentation has been updated.
- [ ] Tests to cover my changes, have been added.
- [ ] All new and existing tests passed?
- [ ] PowerShell code changes: PowerShell v2 compatibility checked?
Related Issue
Fixes #3465
~Note: The MSI task in the GHA ran successfully, but Chocolatey.Cake.Recipe doesn't currently try to upload the MSI on GHA: https://github.com/chocolatey/Chocolatey.Cake.Recipe/blob/e4ac5d739a594f24d62c8502dfa4573da59f5267/Chocolatey.Cake.Recipe/Content/build.cake#L482~
Edit: This is resolved by having the GitHub Action also pick up the MSI and include it with the artifacts.
I have added a commit onto this PR that fixes up the Arguments decryption tests for the Download command.
