choco icon indicating copy to clipboard operation
choco copied to clipboard

(#2762, #2710) Update testing to include testing of stable Chocolatey builds

Open corbob opened this issue 3 years ago • 1 comments

Description Of Changes

  • Update the Vagrantfile used for running tests to be able to run tests against stable releases.
  • Update Contributing.md to move testing section into Testing.md.

Motivation and Context

We need to ensure that newly added tests also succeed with currently stable versions of Chocolatey. If they do not, then they need to be gated on the Chocolatey version so that failing tests aren't accidentally introduced.

Testing

  1. Ran vagrant up TestStable while this branch was based upon commit cce748
  2. Verified that tests failed
  3. Ran vagrant up
  4. Verified that tests passed
  5. Rebased branch off of current develop (136f1c)
  6. Ran vagrant destroy -f
  7. Ran vagrant up TestStable
  8. Verified that tests passed
  9. ran vagrant up
  10. verified that tests passed

Change Types Made

  • [ ] Bug fix (non-breaking change)
  • [x] Feature / Enhancement (non-breaking change)
  • [ ] Breaking change (fix or feature that could cause existing functionality to change)
  • [ ] PowerShell code changes.

Related Issue

Fixes #2762 Fixes #2710

Change Checklist

  • [ ] Requires a change to the documentation
  • [ ] Documentation has been updated
  • [ ] Tests to cover my changes, have been added
  • [ ] All new and existing tests passed.
  • [ ] PowerShell v2 compatibility checked.

corbob avatar Jul 14 '22 21:07 corbob

Coverage Status

Coverage decreased (-0.05%) to 28.482% when pulling eeca4f3dd4cdd2803084838499b8221085ee0790 on corbob:test_stable into 136f1cb0f778d0e50e505b46177ccb97fb7543a9 on chocolatey:develop.

coveralls avatar Jul 14 '22 21:07 coveralls

@corbob just wanted to check that you intended to close this PR, since the two linked issues are still open.

gep13 avatar Jul 12 '23 06:07 gep13

I was doing cleanup of my repositories last night, and either missed that this branch had a PR, or GitKraken didn't show it. In either case it was unintentional to close. I have closed one of the linked issues, as it's not actually needed due to process changes. I'll restore this branch to hopefully get back to updating the testing instructions.

corbob avatar Jul 12 '23 14:07 corbob

@corbob thanks for getting this updated!

gep13 avatar Feb 18 '24 08:02 gep13