chocolatey
(#3721) Support packages.config file in upgrade
Implements a subset of the functionality, support for packages.config files in the upgrade command. Also extended the tests to test the new code. I did not see any value in implementing package.config support for uninstall because the problem I am interested in solving is being able to upgrade multiple packages each with a specific version in one command. Since uninstall (generally?) doesn't require specifying a version this can be done on the uninstall command line, i.e. just give the package list to uninstall.
Closes #3721
Please don't merge master - Merges are very bad in feature branches.
I thought we had that outlined in our CONTRIBUTING document, but it's more implied than called out directly - https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md#submit-pull-request-pr and https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md#respond-to-feedback-on-pull-request
Sorry, I did that via the github web interface which I assumed would do the right thing. I will fix it up....
@Apteryx0 @ferventcoder what's the timeline for getting this merged in? I'm facing a similar use case currently where this feature would make my life easier.
This has a chance to get into the next version. The linked ticket #533 has the milestone. Currently prioritized in 0.10.9.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Russell Mora seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
@Apteryx0 please accept my apologies for the length of time it has taken to get to this milestone. We have recently begun working our way through the backlog of PR's into Chocolatey CLI, and I have been taking a look at this one. We feel that this is a good idea, and it is something that we would like to have available.
I have taken the liberty to create a new issue, rather than linking to the other issue regarding initial support for packages.config file.
This PR will need a little bit of work in order to bring it up to date with the latest code base, but given the length of time that this PR has been open, we can't ask you to work on that, so we will take care of that.
One thing that I would ask is would you be in a position to sign the CLA to allow this code contribution to continue? If not, we will need to recreate the work that you have done here.
Thanks
@Apteryx0 please accept my apologies for the length of time it has taken to get to this milestone. We have recently begun working our way through the backlog of PR's into Chocolatey CLI, and I have been taking a look at this one. We feel that this is a good idea, and it is something that we would like to have available.
I have taken the liberty to create a new issue, rather than linking to the other issue regarding initial support for packages.config file.
This PR will need a little bit of work in order to bring it up to date with the latest code base, but given the length of time that this PR has been open, we can't ask you to work on that, so we will take care of that.
One thing that I would ask is would you be in a position to sign the CLA to allow this code contribution to continue? If not, we will need to recreate the work that you have done here.
Thanks
@gep13 Done! Have at it :-)