cChoco icon indicating copy to clipboard operation
cChoco copied to clipboard

Published 20 hours ago • verified publisher icon chocolatey

(GH-95) Allow for upgrading of packages

Open alphakilo45 opened this issue 5 years ago • 6 comments

This is related to #95 and adds a new resource parameter called UpgradeLowerVersions that causes the cChocoPackageInstall resource to call choco update instead of executing an uninstall/install when the package is already installed and on a lower version.

alphakilo45 avatar Nov 26 '19 22:11 alphakilo45

I went with a UpgradeLowerVersion parameter to avoid changing how the resource works by default (uninstall/install behavior). I would have expected upgrading packages to be the default behavior as well. Also all your comments should now be addressed @pauby

alphakilo45 avatar May 14 '20 20:05 alphakilo45

@alphakilo45 I'm not clear again as to why we are using the parameter UpgradeLowerVersion. I mean I understand why you are using it as you outlined above, but I want to say that Uninstalling and then Installing is not the correct behaviour and it should be a straight upgrade. So that being said we should alter the behaviour? I can't think of any reason why would we not want to?

Thoughts?

pauby avatar May 21 '20 15:05 pauby

@pauby Only reason I can think of is when the build/pre-release tag is the only difference in the version number and that'll still be supported. I'll get the code updated.

alphakilo45 avatar May 21 '20 21:05 alphakilo45

Those tests failed quite spectacularly! Can you rebase and re-push?

pauby avatar Jun 23 '20 11:06 pauby

Agreed - rebase didn't help so I need to find some time on keyboard to figure out what is causing that.

alphakilo45 avatar Jun 26 '20 13:06 alphakilo45

@pauby Looks like Pester released v5 recently and that is causing issues with the tests. I fixed the maxed version in AppVeyor at 4.10.1 (the last pre-5.0.0 version) and tests are now running green.

alphakilo45 avatar Jun 26 '20 14:06 alphakilo45