ChocolateyGUI icon indicating copy to clipboard operation
ChocolateyGUI copied to clipboard

Package uninstall failure error not providing error details.

Open andi3 opened this issue 7 years ago • 4 comments

What You Are Seeing?

When uninstalling a package fails, the results do not include any actionable information.

In version 0.14.0-unstable0245:

chocolatey

In version 1.1.0: 2022-09-30_10-21-00

What is Expected?

Some sort of error output, or an indication that there was no information.

How Did You Get This To Happen? (Steps to Reproduce)

  1. choco install putty.portable
  2. Launch Chocolatey GUI and verify that putty.portable is showing as installed.
  3. choco uninstall putty.portable
  4. In Chocolatey GUI, find putty.portable and attempt to uninstall

Additional Details

The code to generate this message is right here: https://github.com/chocolatey/ChocolateyGUI/blob/1595d271f44f29251c48b43e59c552b8aac37074/Source/ChocolateyGui.Common.Windows/ViewModels/Items/PackageViewModel.cs#L533-L538

System Details

N/A

Output Log

None at this time.

andi3 avatar Apr 12 '17 09:04 andi3

Thanks for reporting this! I've just verified that this appears to be fixed: 2022-09-30_10-21-00

corbob avatar Sep 30 '22 17:09 corbob

Thanks for the initial report @andi3. After some thought, I've reopened this and updated the description with our new Issue Template and expanded on what the current issue is (we don't actually output anything if there are no messages or exceptions).

Also marking it as Up for grabs. A good first pass at this may be to check if the messages and/or exception are empty, and provide a string like "Unable to determine error" in their place.

corbob avatar Sep 30 '22 20:09 corbob

@corbob is this not related to recent work on providing error details from the log?

pauby avatar Apr 16 '24 12:04 pauby

@pauby Although at first glance, it looks like it, I can say that it's not solved by it. I opened up the debugger, and it would seem in the scenario explicitly mentioned here, there are zero log messages being picked up by the log interceptor. Almost like #998, but it's empty even on the first run. It's possible that the UninstallPackage method isn't setting up the log the same as the InstallPackage method is, but that would require more investigation than the few minutes I gave it stepping through the debugger.

corbob avatar Apr 16 '24 23:04 corbob