chmodsayshello

Results 19 comments of chmodsayshello

To be honest, I think in the long term it might be better altering `Game::showOverlayMessage` (see https://github.com/chmodsayshello/minetest/blob/shutdownScreen/src/client/game.cpp#L4369) so by _default_ it shows the sky and uses the indefinite loading added...

> Welcome to paper 👋 thank you for your first PR! Thanks, but this isn't my first PR, have some old ones I have to clean up some day >...

> As a follow up, warrior suggested internally that maybe an event called each time the block is "partially" brushed in the BrushItem useOnTick method would be useful. What would...

I'm sorry for this force push mess, had quite some trouble reverting my changes to the decompile-fixes patch... I'll squash the PR a final time soon

> I do not think this event is needed at all. You can accomplish the same things by listening to the BlockDropItemEvent which, contrary to the linked issue, is fired...

> Why does this need a setting? The console window is a feature pretty much EVERY player interacts with, and it hasn't really changed in years, so I thought one...

> but you can't even open the chat console on Android currently (except by attaching a physical keyboard) Is this something my PR broke? > how does this PR help...

> This does not imply that this PR isn't good to merge as-is (though it would of course be ideal to have the "full package") or that it isn't a...

@Zughy : The PR is ready to me reviewed once again, may you remove "Rebase needed" again please?