sd icon indicating copy to clipboard operation
sd copied to clipboard

binary sd-v0.7.6-x86_64-unknown-linux-musl is not compiled against musl in releases

Open CompuRoot opened this issue 3 years ago • 1 comments

Both files are identical

https://github.com/chmln/sd/releases/download/v0.7.6/sd-v0.7.6-x86_64-unknown-linux-gnu
https://github.com/chmln/sd/releases/download/v0.7.6/sd-v0.7.6-x86_64-unknown-linux-musl

and compiled against gnu libc which makes it isn't portable as it used to be with musl

CompuRoot avatar May 05 '22 06:05 CompuRoot

Just discovered this myself and was about to make a PR. Would be nice to fix this!

mathomp4 avatar May 26 '22 13:05 mathomp4

@CompuRoot

Do you think we can close out this issue? In my fork, I went ahead and published a release using the same CI we have here, and got different files for the gnu and musl builds: https://github.com/yhakbar/sd/releases/tag/v0.7.7-yhakbar

I think it's likely that whatever CI issue caused this in the first place has been resolved.

yhakbar avatar Aug 19 '23 19:08 yhakbar

@yhakbar

Yes, it looks like it compiled now correctly against musl, so let close the issue

CompuRoot avatar Aug 20 '23 04:08 CompuRoot