Christian

Results 265 comments of Christian

@fazho I made the change myself and also updated the release notes and added a comment. Please let me know if you agree with the changes (especially the comment). After...

@tufberg Please put the expected code in a comment. I will not download any files to my machine. Or is it the code from https://github.com/dotnet/MQTTnet/issues/1978#issuecomment-2082551516

@rido-min Do you think the following code is a good practice which can be added to the library as the default behavior or do you think it has higher potential...

Thanks for sharing your thoughts. Then I will expose the certificate selection handler in the MQTTnet options and do not implement a default handler. MQTTnet will choose the best constructor...

I recommend keeping an external queue which is fed from a receiving client. Another sending client should monitor the queue and send the data as soon as there is any.

I like the idea of working with templates but in my opinion it should not be part of the core library. I would rather move it to an extension library...

@simonthum I applied the code style from the team shared settings in Rider and also extended the release notes. If you agree with the changes I will merge the PR

@mregen You mentioned that the library is currently doing additional copies. But I was not able to identify them. The entire packet is sent in basically two parts (the header...

@mregen In my opinion we should not drop support for an array segment right now. From what I already see in the PR we should be able to make it...

Having a new property at the _MqttApplicationMessage_ sounds good to me. For the upcoming version 5 we can delete all other variations of the payload because we may have several...