pty.js include binaries for windows version

include binaries for windows version

Open soliton4 opened this issue 10 years ago • 17 comments

as i tested successfully in nodeMirror, delivering binaries for windows is possible in npm. so i request the feature that windows binaries are available by default.

Oct 19 '13 20:10 soliton4

I'm open to doing this once there's an officially sanctioned way to do this with node/npm (see https://github.com/isaacs/npm/issues/1891). I'm not gonna bother with writing manual downloading scripts from s3, etc.

Oct 19 '13 20:10 TooTallNate

its way easier than this. mind if i create a PR?

Oct 19 '13 20:10 soliton4

see https://github.com/chjj/pty.js/pull/50

Oct 22 '13 00:10 soliton4

I am not trying to sound like a prick or ungrateful, but you really need to provide Windows binaries. pty.js is the standard way to do terminals in Node. If there is not an "official" way to provide binaries for node, then you then to find a way to release a binary that is safe or make an official way to release Node binaries. It is asking way too much to require people to download and install over 6GB (or whatever the size of Visual Studio is now a days) to install a single library and that does not account for version issues with MSBuild or anything. I still have not been able to get pyt.js to build on two different computer (one running Windows 7 with VS2012 Express and one running Windows 10 with VS2013 Ultimate).

As you can see above, the Github editor Atom is having serious issues installing on Windows because of pty.js. If you want to keep pty.js as the standard way of doing terminals in Node, then you will have to support Windows. winpty has binaries compiled for MSYS and Cygwin. I am sure you can use those.

I am seriously considering not using pty.js or @chjj other project blessed and just going back to Python for my current project. At least there I will get proper support for Windows.

Jun 30 '15 14:06 AngellusMortis

@AngellusMortis i am providing my own windows binray in nodeMirror feel free to have a look https://github.com/soliton4/nodeMirror/tree/master/lib/pty-win/build/Release

Jun 30 '15 14:06 soliton4

+1 Having also issue installing an Atom package on Windows that depends on this.

See: https://github.com/webBoxio/atom-term2/issues/132