Christopher Jeffrey (JJ)

buffer: fix DoS vector in atob

36

I know the consensus is that this function shouldn't be optimized, but the [`O(n*70)` worst case complexity of the loop][1] isn't mentioned in the docs. In fact, the comments in...

Discussed here: https://news.ycombinator.com/item?id=7080339

Implements [Buffer.copyBytesFrom][1]. Also fixes a bug with `ERR_INVALID_ARG_TYPE`. [1]: https://nodejs.org/docs/latest/api/buffer.html#static-method-buffercopybytesfromview-offset-length

Drop base64-js dependency, and optimise Buffer.write

8

Most string `write` functions (with the exception of `hexWrite`) were allocating arrays before copying them onto the buffer. This resulted in significant performance overhead. This PR modifies said functions to...

Not sure whether this helps performance, but subarrays only need augmenting pre-ES2016. Might be good to avoid it if we can. The code detects whether `TypedArray#subarray` calls the child class'...

Extension block testnet (extnet)

1

I've set up an early testnet for extension blocks (extnet) running on bcoin. - Seed: 45.33.50.84:58901 - Faucet: http://45.33.50.84:8080 Parameters and genesis block reside in: https://github.com/bcoin-org/bcoin-extension-blocks/blob/extblk/lib/protocol/networks.js#L782 This is still an...

I'm a huge fan of [libnettle]. It's really small, well-written, and easily auditable. We could vendor it and statically link to it. Switching would solve issues like #15. It would...

Some major backward-incompatible changes coming for the next version. Documenting them here. ### AES - `./lib/aes` has been removed. Use `./lib/cipher` instead (maybe -- on the fence with this one)....