flexsurv-dev icon indicating copy to clipboard operation
flexsurv-dev copied to clipboard

New S3 methods for fmsm objects

Open mattwarkentin opened this issue 2 years ago • 2 comments

Hi @chjackson,

Would you be open to a pull request for a new predict.fmsm method for the predict S3 generic? I would generally match the argument signature to the predict.flexsurvreg method, where applicable.

The predict.fmsm method would wrap pmatrix.fs/pmatrix.simfs and totlos.fs/totlos.simfs. Thus, the prediction types could be: 'prob' and 'totlos'.

I would also be interested in adding a tidy.fmsm method that ostensibly does purrr::map_dfr(fmsm_obj, tidy, .id = 'trans').

What are your thoughts?

mattwarkentin avatar Jun 01 '22 15:06 mattwarkentin

Both of those sound good - thanks!

chjackson avatar Jun 06 '22 16:06 chjackson

@mattwarkentin would be interested in those too - you would not happen to have a PR lying around ;) ?

kkmann avatar Feb 08 '23 14:02 kkmann