Chitrang Patel

Results 201 comments of Chitrang Patel

> will these tests be blocking as soon as this PR is merged? I think once this PR is merged, within an hour or so I think (whenever our CI...

> Thanks for the release-note! Shall we also add the changes to somewhere https://github.com/tektoncd/pipeline/blob/main/docs/pipelines.md#specifying-parameters? Done. PTAL again 🙏 Thanks!

/test pull-tekton-pipeline-alpha-integration-tests

/test pull-tekton-pipeline-go-coverage-df

> On second thought - do we need an integration test for this? I threw in an example test for this. If that's not ok, I can work on an...

> I tend to agree with the issue #7901 to be an extension of the capability of the existing API. > > While this PR generally lgtm, shall we also...

/hold cc @afrittoli I put a hold so that we can all be on the same page here. Let's discuss it on the [issue](https://github.com/tektoncd/pipeline/issues/7901) or in the API WG on...

/hold cancel Synced offline with @afrittoli! We are all on the same page now that this is an oversight and should be fixed.