chirokas comments

Repositories
Issues
Comments

Results 12 comments of


                                            chirokas

Collection is not built when `React.Activity` is set to `visible` the first time

> do you know why `setProps` isn't called in the mount phase? FYI: Refs are treated as layout effects. https://github.com/facebook/react/blob/fb2177c153353621c5e343b0386993e5084f641e/packages/react-reconciler/src/ReactFiberCommitWork.js#L782-L802 When switching from hidden to visible, reappearLayoutEffects attaches the refs....

fix(modal): onOpenChange triggering when modal opens

- The current commit causes `onOpenChange` to trigger twice when in an uncontrolled state. - Should we treat [this](https://github.com/nextui-org/nextui/issues/3887) as incorrect usage rather than a bug? 🤔 See [here](https://stackblitz.com/edit/vitejs-vite-sufbgs?file=src%2FApp.tsx).