react-native-mail icon indicating copy to clipboard operation
react-native-mail copied to clipboard

Published 20 hours ago • verified publisher icon chirag04

Fix Outlook and Windows Attachment issues, resolve merge conflict

Open MaxPMagee opened this issue 3 years ago • 6 comments

This PR is based on work that @kacyn did for the original PR here https://github.com/chirag04/react-native-mail/pull/65

This also supports attachments in Outlook within Android

MaxPMagee avatar Jun 30 '21 18:06 MaxPMagee

Are there any drawbacks to using this change? Can you explain it? Do all clients except Outlook have a non-null "attachment" option? Thanks,

bruscantini avatar Sep 02 '21 09:09 bruscantini

Unfortunately, I was not the original author, I just resolved the merge conflicts that cropped up months after the original PR. As I say here, I need someone who is a domain expert to review it. https://github.com/chirag04/react-native-mail/pull/65#issuecomment-871640479

MaxPMagee avatar Sep 02 '21 13:09 MaxPMagee

@MaxPMagee gotcha! Upon checking his comments in that PR, I think the first change is just for cases where the email has an attachment. I guess Outlook needs that when sending an attachment.

The second change is absolutely necessary for Outlook to work. I've actually been using that change in my app for some time now. I just had to upgrade the lib recently so I've had to revisit it :)

bruscantini avatar Sep 03 '21 09:09 bruscantini

@bruscantini I think you meant to tag @MaxPMagee not me?

mars-lan avatar Sep 03 '21 11:09 mars-lan

Yup @mars-lan sorry about that one. It wasn't prefilling his username for me.

bruscantini avatar Sep 03 '21 12:09 bruscantini

Is anyone looking into it, facing issue with outlook. Body not rendering when isHtml is set to true

project-sense avatar Dec 27 '22 05:12 project-sense