distant icon indicating copy to clipboard operation
distant copied to clipboard

Split arguments based on windows/unix

Open chipsenkbeil opened this issue 3 years ago • 1 comments

Today, we split arguments using shell-words crate, but this only handles POSIX shell arguments.

To support Windows, we need to implement an alternative split that we can use when we know the machine is windows. Because this could be run on one of two different shells (minimum), we either need to control which shell runs the command OR support multiple escape syntax.

chipsenkbeil avatar Jul 30 '22 14:07 chipsenkbeil

See https://github.com/tmiasko/shell-words/issues/14 for open issue with shell-words crate.

chipsenkbeil avatar Jul 30 '22 16:07 chipsenkbeil

done in branch

chipsenkbeil avatar Aug 05 '22 07:08 chipsenkbeil

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Jul 08 '23 03:07 github-actions[bot]