fasm
fasm copied to clipboard
chipsalliance
FPGA Assembly (FASM) Parser and Generator
Ref #54 As a first step towards understanding the differences between workflows, all of them are merged. The three of them are triggered by the same events anyway...
Convert the library to use `setuptools_scm` module rather than my own hacky script. TODO Items; - [ ] Improve the version file that is being generated. - [ ] Figure...
The three workflows we now have seem to be almost identical? See; - https://github.com/SymbiFlow/fasm/blob/master/.github/workflows/presubmit.yml - https://github.com/SymbiFlow/fasm/blob/master/.github/workflows/wheel.yml - https://github.com/SymbiFlow/fasm/blob/master/.github/workflows/publish-to-pypi.yml
The cmake file needs some improvement. It should add; - Add `-Wimplicit-fallthrough=0` if it is supported on non-Windows - Add `-Wno-attributes` if it is supported on non-Windows - Add `/std:c++latest`...
The pull request at #48 adds a `add_flags` method. These flags should be instead correctly set via detection in the cmake file. The code is shown below; ```python def add_flags(self):...
It would be much easier if these were separate packages.
Currently cmake complains heavily during the build, figure out what needs to be done to fix the issues; ``` CMake Warning (dev) at /usr/local/share/cmake-3.19/Modules/ExternalProject.cmake:2143 (message): Policy CMP0114 is not set:...
The --no-use-pep517 flag is needed to select between shared and static installs because there is currently no way to pass flags with PEP517. Relevant issue: https://github.com/pypa/pip/issues/5771
There is no instructions at https://github.com/SymbiFlow/fasm/tree/master/third_party/antlr4 which explain how to update antlr to the newer version.