plyr-react icon indicating copy to clipboard operation
plyr-react copied to clipboard

Published 20 hours ago • verified publisher icon chintan9

Mark css files as side effects

Open desfero opened this issue 2 years ago • 10 comments

Right now production build of parcel (and all other bundlers that take into account sideEffects flag) removes the css files completely from the bundle.

Specifying explicitly that css has side effects would solve the issue.

desfero avatar Sep 26 '22 11:09 desfero

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 26 '22 11:09 sonarqubecloud[bot]

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code. This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% Chintan Prajapati 103 1
100.00% amirHossein-Ebrahimi 29 1
100.00% tractorcow 1 1

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
package-lock.json91.20%808 out of 886 times

Committed file ranks

  • 99.49%[package.json]

    • vizipi[bot] avatar Sep 26 '22 11:09 vizipi[bot]

    Any update on this PR? Can it be merged?

    cesarenaldi avatar Nov 21 '22 13:11 cesarenaldi

    👇 Click on the image for a new way to code review

    Review these changes using an interactive CodeSee Map

    Legend

    CodeSee Map legend

    ghost avatar Dec 02 '22 02:12 ghost

    Hey @desfero nad @cesarenaldi

    We copy the CSS file after building in postbuild our scripts

    https://github.com/chintan9/plyr-react/blob/0e6459f0b3c1da51f26d9a262969b110b7da1201/package.json#L52-L56

    I checked the latest version of dist.tarball from npm view command and it seems that we have the plyr.css in our final build.

    I always thought that the "sideEffects" is mostly going to be used for tree-shaking.

    realamirhe avatar Dec 02 '22 08:12 realamirhe

    Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

    Bug A 0 Bugs
    Vulnerability A 0 Vulnerabilities
    Security Hotspot A 0 Security Hotspots
    Code Smell A 0 Code Smells

    No Coverage information No Coverage information
    0.0% 0.0% Duplication

    sonarqubecloud[bot] avatar Dec 19 '22 21:12 sonarqubecloud[bot]

    it changes the side effect property for all end devs so it needs more investigation before merging!

    realamirhe avatar Dec 19 '22 21:12 realamirhe

    Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

    Bug A 0 Bugs
    Vulnerability A 0 Vulnerabilities
    Security Hotspot A 0 Security Hotspots
    Code Smell A 0 Code Smells

    No Coverage information No Coverage information
    0.0% 0.0% Duplication

    sonarqubecloud[bot] avatar Apr 17 '23 17:04 sonarqubecloud[bot]

    Any update here? 🤔

    al-petrushin avatar Dec 14 '23 09:12 al-petrushin

    Quality Gate Passed Quality Gate passed

    Kudos, no new issues were introduced!

    0 New issues
    0 Security Hotspots
    No data about Coverage
    0.0% Duplication on New Code

    See analysis details on SonarCloud

    sonarqubecloud[bot] avatar Dec 26 '23 01:12 sonarqubecloud[bot]