angular-charts icon indicating copy to clipboard operation
angular-charts copied to clipboard

Code organized into more elegant structure.

Open Oleg-Imanilov opened this issue 10 years ago • 5 comments

Project changed to support multiple src files.

Important: templates & *.mdl.js - must be included first, the rest *.js files may be included in any order after it.

js files naming:

*.mdl.js - modules description *.dir.js - directives *.srv.js - services (factories etc) *.ctrl.js - contollers

For now I only moved the code to separate files. There is more refactory needed to reuse some parts of the components.

Oleg-Imanilov avatar Sep 23 '14 17:09 Oleg-Imanilov

The tooltip exceptions were fixed in PR #137

I like the file splitting, keeps the alphabetical issue out of the way

chaosfinity avatar Sep 23 '14 18:09 chaosfinity

Im sorry i take that back they didn't make it into the commit

chaosfinity avatar Sep 23 '14 18:09 chaosfinity

If it looks scary to you, I can explain :-) But after splitting it will be much easier to develop & marge.

Oleg-Imanilov avatar Sep 23 '14 20:09 Oleg-Imanilov

Hey Oleg, Thanks much for the PR!

It does look scary, and I think we should hold off splitting files until we remove redundancy in codebase. It will be easier that way. I like to organization of codebase, and this is definitely a way I would want to follow, but not immediately. Meanwhile there are actually some changes going in parallel, you can check them in other branch here

chinmaymk avatar Sep 23 '14 20:09 chinmaymk

It is very difficult to manage changes and/or merges with one single file. The redundancy handling will be much easier in smaller files. After the split, we can finally use angular.extends etc. for copy/past code. Alternative is to merge my change with PR branch, but it will be almost impossible to merge it with master after few changes. Believe me, as earlier the split will be merged - the project will be more stable and the fixes can be isolated.

I will do additional refactoring to reduce redundancy, but it can be made only after split :-( Please, think again. As I said , there no changes in logic - only code move!

Oleg-Imanilov avatar Sep 23 '14 21:09 Oleg-Imanilov