Chinedu Okoli

Results 8 comments of Chinedu Okoli

> @kanishka-ghosh I have thought about this a little bit more, and I am beginning to wonder if this is the wrong way to go about modeling these systems. Notably,...

`test_units_consistent` failure is from `DAE transformation`. `Pyomo.DAE` does not account for the units of the ContinuousSet (time, space etc) in the transformed `DerivativeVar` expression thus leading to the `InconsistentUnitsError` for...

> @chineduobiora The unit consistency problem is a know issue in Pyomo [Pyomo/pyomo#1790](https://github.com/Pyomo/pyomo/issues/1790) How do we resolve it for this PR so the tests don't fail?

All review comments have been addressed. @andrewlee94 and @bpaul4 do you have ideas why the "check code formatting (Black)" test is failing. I've run black on my local machine without...

> @chineduobiora it appears the files `moving_bed.py` and `bubbling_fluidized_bed.py` are not Black-formatted. That's what it says but I've black-formatted them on my local repo.

> @chineduobiora First thing to do is make sure you are using a compatible version of `black`. Ahh. That might be it. Thanks.

@andrewlee94 @bpaul4 @Daison2102, all review comments have been addressed and all tests pass, let me know if there are any additional comments you have. Also, note that the TSA example...

> @chineduobiora I have no further comments on the model, everything looks good. If you'd like to test the example before the model is merged, you could temporarily change the...