superplaceholder.js icon indicating copy to clipboard operation
superplaceholder.js copied to clipboard
verified publisher icon chinchang

improve javascript

Open marcobiedermann opened this issue 9 years ago • 6 comments

Improve JavaScript:

  • Cache window and document object
  • Hoist variables in for statement to top of function
  • Replace space indentation with tabs
  • Improve coding style

marcobiedermann avatar Mar 08 '16 09:03 marcobiedermann

@marcobiedermann Looks good. Please remove the dist/* files from this PR. They will be auto generated when PR is merged into master.

chinchang avatar Jun 13 '16 12:06 chinchang

@chinchang I've updated my pull request to your suggested changes!

marcobiedermann avatar Jun 14 '16 10:06 marcobiedermann

@chinchang BTW, how do you auto generate the files in dist? Do you use some git hooks or any third party service?

marcobiedermann avatar Jun 14 '16 10:06 marcobiedermann

@marcobiedermann I think there is confusion...the dist/ files were to be removed from your PR, but I think you removed them from the repo itself :) Just that your PR changes should not show any change regarding dist/ files

chinchang avatar Jun 14 '16 10:06 chinchang

Right now its a local script that does the tagging, building etc stuff whenever a release is ready on master. But I suppose I could do that with travis as well.

chinchang avatar Jun 14 '16 10:06 chinchang

Ping @chinchang 😄

marcobiedermann avatar Sep 08 '16 19:09 marcobiedermann

I'm closing this issue because this project is no longer being maintained

marcobiedermann avatar Sep 26 '22 15:09 marcobiedermann