hint.css icon indicating copy to clipboard operation
hint.css copied to clipboard

Hint does not hide when aria-label is not present

Open minimih opened this issue 9 years ago • 6 comments

This hides the Tooltip: <a class="hint--left" aria-label="">Left</a>

This does not hide the Tooltip: <a class="hint--top">Top</a>

minimih avatar Sep 08 '16 18:09 minimih

could you please assign this task to me I would like to work upon it

sureshkumarAQ avatar Oct 10 '21 17:10 sureshkumarAQ

@chinchang can you assign this to me. I will resolve it

Wimukti avatar Oct 17 '21 17:10 Wimukti

@sureshkumarAQ you still up for fixing this?

chinchang avatar Oct 19 '21 19:10 chinchang

@sureshkumarAQ you still up for fixing this?

Yeah chinchang !! could you please guide me a little bit where to start ? I`m not getting it properly.

sureshkumarAQ avatar Oct 20 '21 05:10 sureshkumarAQ

@sureshkumarAQ The selectors in the hint-core.scss file will need tweaking. In case the aria-label is empty, the :after element doesn't show because of undefined content value (content: attr(aria-label)). But the :before shows because it has valid content: ''. To fix this we should change the showing of :after and :before to only when aria-label isn't undefined or empty string.

chinchang avatar Apr 15 '24 06:04 chinchang