code-blast-codemirror icon indicating copy to clipboard operation
code-blast-codemirror copied to clipboard

Configurable shakeIntensity

Open Jeongmin-Lim opened this issue 7 years ago • 4 comments

Hi, I'm applying your project to mine, and I need to change shakeIntensity and size of particle of effect 2. (I wanted to lower these) However, there aren't configurable options about these yet. So I made some options for my use and if you are interested in, let me know. I'll open pull request.

You can find my works at this compare and I also updated demo, you can check how it works.

Any suggestions are welcome.

Thanks to your great work. :) Jayde.

Jeongmin-Lim avatar May 11 '17 03:05 Jeongmin-Lim

is it possoble to apply your works to effect 1?

won0c avatar Jun 08 '17 03:06 won0c

@won0c Sorry!! I'm terribly late to reply :( To answer your question, of course it is possible. I will update my work right now.

Jeongmin-Lim avatar Jun 23 '17 05:06 Jeongmin-Lim

@won0c I updated my work that applies to effect 1 at this commit I changed default maxParticleSize value as 0, because we need to apply different default maxParticleSize to each effects.

Jeongmin-Lim avatar Jun 23 '17 06:06 Jeongmin-Lim

@Jayde-Im Yes! Please open a PR 👍

chinchang avatar Jun 26 '17 11:06 chinchang