crux icon indicating copy to clipboard operation
crux copied to clipboard

Published 20 hours ago • verified publisher icon chimbori

Preserve <br>?

Open 8enmann opened this issue 5 years ago • 4 comments

I tried extracting https://us13.campaign-archive.com/?u=67bd06787e84d73db24fb0aa5&id=c3e998f811&e=7bc177b38a

and then rendering it. Looks broken since the
are extracted. Can I send a PR to add them back? What's the best way to do this?

8enmann avatar Oct 15 '18 23:10 8enmann

Sure, PRs are always welcome! See CONTRIBUTIONS for how to send one.

At a minimum, please add a new test with the content you are trying to parse, and then modify the source so that your new text is parsed correctly (while ensuring that existing tests also continue to pass.)

chimbori avatar Oct 24 '18 22:10 chimbori

Decided to use mozilla/readability instead since it's a bit more robust. Thanks!

8enmann avatar Oct 25 '18 03:10 8enmann

True, it’s been around longer & has more maintainers.

Though, it’s written in JavaScript, which precludes many usages of it, especially in Android apps. Crux’s predecessor, Snacktory, started as a Java clone of Readability.

chimbori avatar Oct 25 '18 04:10 chimbori

In Android I'm injecting it into a WebView and extracting output with webview.evaluateJavascript 😅

8enmann avatar Oct 25 '18 04:10 8enmann