Results 74 comments of Charles Hill

Hello! Thanks for taking the time to create a PR. I am not so familiar with TypeScript, but I am open to including these definitions in the project. Are there...

@HoldYourWaffle What's the status on this? Have the upstreams merged your other PRs?

Looks like you're trying to save session data that includes characters not included in the utf8 encoding.

Looks like the following stackoverflow post could help you: https://stackoverflow.com/questions/20411440/incorrect-string-value-xf0-x9f-x8e-xb6-xf0-x9f-mysql You might need to change a MySQL configuration so that it's using the "utf8mb4_general_ci" or "utf8mb4_bin" encoding.

In your application logic, you can delete the session of the active user when they logout. The express-session module adds the session ID to the request object of express as...

I think what is happening is a SQL query is running somewhere that is holding a record lock on the record (or many records) in the session table. Then when...

If you have millions of sessions with only a few thousand users, then I suspect you have a very very long expires time (e.g 1 year). If that's the case,...

I think it should still work. You could try it with a test database and then run the tests - to be sure.

I found a [nice answer on stackoverflow](https://stackoverflow.com/a/23517191) that explains this [behavior in MySQL](https://dev.mysql.com/doc/refman/8.0/en/insert-on-duplicate.html): > If you specify ON DUPLICATE KEY UPDATE, and a row is inserted that would cause a...

This looks like an issue with the [express-session module](https://github.com/expressjs/session).