widget-3dviewer icon indicating copy to clipboard operation
widget-3dviewer copied to clipboard

Missing .js extension on three library breaks 3d viewer with black background

Open trailhead opened this issue 8 years ago • 3 comments

This path appears to be broken... https://cdnjs.cloudflare.com/ajax/libs/three.js/r79/three

This appears to be a valid path, but I can't confirm it fixes the viewer https://cdnjs.cloudflare.com/ajax/libs/three.js/r79/three.js

trailhead avatar Oct 26 '16 17:10 trailhead

You don't put .js extension when listing files in require.js. Problem is not with this widget. It is with other ones that reference three that are not updated to the cdn. Then load order is random.

On Oct 26, 2016 10:08 AM, "Trailhead" [email protected] wrote:

This path appears to be broken... https://cdnjs.cloudflare.com/ajax/libs/three.js/r79/three

This appears to be a valid path, but I can't confirm it fixes the viewer https://cdnjs.cloudflare.com/ajax/libs/three.js/r79/three.js

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chilipeppr/widget-3dviewer/issues/6, or mute the thread https://github.com/notifications/unsubscribe-auth/AHidbZcETKpsKoN1j38YnXEuw_pPWxBmks5q34kpgaJpZM4KhbZs .

chilipeppr avatar Oct 26 '16 17:10 chilipeppr

Ok, gotcha. Not an expert at the JS stuff but I can look at the console and poke at a repo. :D

trailhead avatar Oct 26 '16 17:10 trailhead

Try now. Should be fixed. I updated reference to all widgets that use Three.js to point to an exact version now:

Three: 'https://cdnjs.cloudflare.com/ajax/libs/three.js/r76/three',

On Wed, Oct 26, 2016 at 10:36 AM, Trailhead [email protected] wrote:

Ok, gotcha. Not an expert at the JS stuff but I can look at the console and poke at a repo. :D

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chilipeppr/widget-3dviewer/issues/6#issuecomment-256422209, or mute the thread https://github.com/notifications/unsubscribe-auth/AHidbQ1wy0NUohn5gsOZmlCkminofp7Xks5q34-3gaJpZM4KhbZs .

chilipeppr avatar Oct 27 '16 15:10 chilipeppr