tinyg icon indicating copy to clipboard operation
tinyg copied to clipboard

Auto-probe doesn't work with TinyG2 hardware

Open karlbackstrom opened this issue 9 years ago • 3 comments

Hi,

I have a Arduino Due with a gShield attached and running edge branch of the g2 firmware. In Chilipeppr the auto-level function was hanging on the first probe. The reason for the hanging is that the reply has changed between TinyG and TinyG2. The "prb" entry in the reply is now at top level. After changing the reply checking in the widget the auto-level is now working.

Just my 2 cents if other people have the same problem.

Line 1344:

if ('prb' in json) { // Changed line
   // we hit the probe bottom. awesome. done.
   chilipeppr.unsubscribe("/com-chilipeppr-widget-serialport/recvline", that, callback);

   console.log("got to end of G38.2 cmd");
   probe.z = json.prb.z; // Changed line

   probe.done = true;

karlbackstrom avatar May 18 '15 00:05 karlbackstrom

Good catch. I bet we could look for both and cover both versions. On May 17, 2015 5:13 PM, "Karl Backström" [email protected] wrote:

Hi,

I have a Arduino Due with a gShield attached and running edge branch of the g2 firmware. In Chilipeppr the auto-level function was hanging on the first probe. The reason for the hanging is that the reply has changed between TinyG and TinyG2. The "prb" entry in the reply is now at top level. After changing the reply checking in the widget the auto-level is now working.

Just my 2 cents if other people have the same problem.

Line 1344:

if ('prb' in json) { // Changed line // we hit the probe bottom. awesome. done. chilipeppr.unsubscribe("/com-chilipeppr-widget-serialport/recvline", that, callback);

console.log("got to end of G38.2 cmd"); probe.z = json.prb.z; // Changed line

probe.done = true;

— Reply to this email directly or view it on GitHub https://github.com/chilipeppr/tinyg/issues/23.

chilipeppr avatar May 18 '15 03:05 chilipeppr

Indeed, thanks for a very nice program.

karlbackstrom avatar May 18 '15 04:05 karlbackstrom

Thanks for the bug fix! On May 17, 2015 9:12 PM, "Karl Backström" [email protected] wrote:

Indeed, thanks for a very nice program.

— Reply to this email directly or view it on GitHub https://github.com/chilipeppr/tinyg/issues/23#issuecomment-102916773.

chilipeppr avatar May 18 '15 04:05 chilipeppr