serial-port-json-server icon indicating copy to clipboard operation
serial-port-json-server copied to clipboard

Default Websocket URL is incorrect in README.md

Open aeronth opened this issue 3 years ago • 1 comments

The README.md says that the websocket URL is ws://localhost/ws by default, but it is actually on port 8989 as well, so the correct default URL for the websocket is ws://localhost:8989/ws or ws://<ipaddress>:8989/ws.

It would save a few minutes of confusion and Googling if the README were updated. Thanks!

aeronth avatar Nov 21 '21 13:11 aeronth

Would you mind doing a pull request and I'll approve it asap?

On Sun, Nov 21, 2021 at 7:10 AM Aeron @.***> wrote:

The README.md says that the websocket URL is ws://localhost/ws by default, but it is actually on port 8989 as well, so the correct default URL for the websocket is ws://localhost:8989/ws or ws://:8989/ws.

It would save a few minutes of confusion and Googling if the README were updated. Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chilipeppr/serial-port-json-server/issues/71, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4J23KJPNACHMH7DZYBSIDUNDVUFANCNFSM5IPESMMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

chilipeppr avatar Nov 21 '21 15:11 chilipeppr