Quill embedded LearingItems TODOs

[Ruchiranga]

future:

• [ ] marker when dragging, and auto-scroll to more easily place dragged item

now:

• [ ] Fix messed up author colors when pasting big content with range selected
• [ ] Fix issue with 4 panes
• [ ] Embedded richtext not working on edit mode
• [ ] Fix shift+delete
• [x] always scroll to bottom after typing/inserting if the cursor was at the end
• [x] move, or copy the LI with a new ID and insert
• [x] if you put a LI in thumbnail, delete, and undo (Cmd+Z), it is put back in full view
• [x] add a copy button to LI
• [x] bonus task, click on LI to select and copy - not important
• [x] Allow pasting content inside embedded LIs
• [x] Prevent scroll from jumping on pasting content
• [x] Optimize re-rendering to avoid editor being sluggish
• [x] issue with shortened code formatted text
• [x] Editing window should be as large as containing window, but not larger (ie. it should not cause the containing div to overflow)
• [x] Allow adding content before an LI at index 0
• [x] when range-select LI and copy, make sure maintaining \n distance
• [x] LI content overflowing LI box when rich text window is very small, but overflow: none or sth.
• [x] Toggle author colors if there is only one student
• [x] Fix messed up CSS in hypothesis
• [x] Add + handler to toolbar to add new LIs
• [x] Make the section of view between thumb and full collaborative
• [x] Ability to select edit, full, thumb views when hovered over LI
• [x] Error with full display of Richtext in chat
• [x] Ensure newlines before and after a LI
• [x] Register authorship globally
• [x] Fix embedded LIs in an LI in edit mode duplicating when a new LI is added (steps to reproduce: Open 2 student windows, add one RTLi with some text, add another RTLi with the first one embedded. Have the latter in edit mode in both students, add another new RTLi. The embedded Lis in the edit mode Li duplicates)
• [x] Data issue https://github.com/chili-epfl/FROG/issues/1552#issuecomment-444756050
• [x] Fix "Can't call setState (or forceUpdate) on an unmounted component" warning (steps to reproduce: drag RTLI to editor and add it, drag another RTLI to the editor)
• [x] Avoid passing dataFn LearningItem with insert embed
• [x] Add better css to LI background
• [x] Set bounds to editor
• [x] Register LI blot once globally
• [x] Insert dropped LIs at cursor location
• [x] Authorship integration

[houshuang]

There seems to be something weird going on, maybe related to data coordination. I had two students open, and several LIs, then I deleted a newly added LI, and suddenly all three remaining LIs were showing the deleted LI in one window, whereas all three LIs were showing the same Tweet in another window...!

[houshuang]

If you delete a LI, and undo, it will spin. Somehow the LI ID becomes '[object Object]'

[Ruchiranga]

Is this on the latest quill-embed-react-comp branch? I could not reproduce this.

[houshuang]

This is my latest commit commit 48a40f20447a432bd1901686f3dcfb78618e2b86 (HEAD -> quill-embed-react-comp, origin/quill-embed-react-comp)

See video https://www.dropbox.com/s/wbpjrjlziyz4flq/LI%20reloading.mov?dl=0

[houshuang]

Fixing this

[Ruchiranga]

Thanks :)